Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update documentation and improve error message #10117

Merged

Conversation

guoguojin
Copy link
Contributor

Closes #10103

The API works as it should but the error returns a bad error that makes users think something has gone wrong. Also the API documentation is not consistent between the gRPC and GQL documentation and doesn't make it clear what is required in the GQL version.

The error message now returns:

{
  "errors": [
    {
      "message": "invalid filter",
      "path": [
        "ledgerEntries"
      ],
      "extensions": {
        "code": 3,
        "type": "InvalidArgument"
      }
    }
  ],
  "data": null
}

@guoguojin guoguojin force-pushed the fix/10103-list-ledger-entries-filter-transfer-type branch from 94b38a4 to 1e37f02 Compare November 16, 2023 12:33
@guoguojin guoguojin merged commit ab21d2a into develop Nov 16, 2023
20 checks passed
@guoguojin guoguojin deleted the fix/10103-list-ledger-entries-filter-transfer-type branch November 16, 2023 14:40
jeremyletang pushed a commit that referenced this pull request Nov 17, 2023
…ries-filter-transfer-type

fix: update documentation and improve error message
@gordsport gordsport added the bug label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API]: GraphQL: LedgerEntries fails if TransferType filter is specified
5 participants