fix: ensure we hit leave auction trigger on mark-price calc, and hand… #10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwestgarth
force-pushed
the
10858-auction-state-sync
branch
2 times, most recently
from
4c16e5c
to
2a8c33d
Compare
witgaw
previously approved these changes
Mar 11, 2024
| return | ||
| } | ||
|
|
||
| st, nd := a.auctions[len(a.auctions)-2], a.auctions[len(a.auctions)-1] |
There was a problem hiding this comment.
start, end rather than st, nd would save a little bit of mental effort.
wwestgarth
force-pushed
the
10858-auction-state-sync
branch
from
725ead4
to
392cb07
Compare
…le zero length auction intervals in perpetual
wwestgarth
force-pushed
the
10858-auction-state-sync
branch
from
3588003
to
2e15bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10858
The addition of the check that the mark price calculation can trigger a price auction was causing the book-keeping of enter/leaving auctions for perpetuals to become out of sync.
We now tell the perp that we are leaving when we call
as.Left()and then update it again to entering an auction if the price-monitoring is triggered. The perpetual then just handles this zero length interval.Another interesting thing is that the flow was a bit borked in
leaveAuction()where price monitoring is triggered by the mark price calculation, we would never hit the call toenterAuction()after the call toCalculateMarkPrice()but would by luck start the auction by falling intocommandLiquidityAuction().I've changed the check in
updateMarkPriceIfNotInAuction()to properly return anerrif we hit price-monitoring, hopefully this does not cause integration tests to fail.