Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cache map to order sqlsubscriber #11275

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

EVODelavega
Copy link
Contributor

No description provided.

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
@Sohill-Patel
Copy link
Contributor

system-test test_submit_and_cancel_orders

here is the test run that demonstrates the issue
https://jenkins.vega.rocks/job/common/job/system-tests-wrapper/58161/testReport/junit/tests.market_depth/market_depth_spot_test/test_submit_and_cancel_orders/

and then we run the same test on this branch to prove its fixed
https://jenkins.vega.rocks/job/common/job/system-tests-wrapper/58162/

in the passing test you can see below an example of an order that is created in same block as it is cancelled
{"id":"226-14","block":"F1303173884E3F40F24639E4AC1189ECBC0DB0FF92E6A72075960687524A31DF","type":"BUS_EVENT_TYPE_CANCELLED_ORDERS","cancelledOrders":{"marketId":"b26d8011ce0e3fba69171cd103b27c9d3ff5f04d1cd57c2e482273236e5840c5","partyId":"eef5f5aa729d102ecf6ca6e9b21ed4adea40b97f427cc7c2a9c3335e671a4dff","orderIds":["96c1a08e0828f7becee080a027d56bd858f52f9361f72a1bd485f695a0b2c56f"]},"version":1,"chainId":"testnet-001","txHash":"5695CEB0114E7236ACF9240F71E293E00C46AFAC5E5775E7FE45098944F47DBA"}

{"id":"226-14","block":"F1303173884E3F40F24639E4AC1189ECBC0DB0FF92E6A72075960687524A31DF","type":"BUS_EVENT_TYPE_CANCELLED_ORDERS","cancelledOrders":{"marketId":"b26d8011ce0e3fba69171cd103b27c9d3ff5f04d1cd57c2e482273236e5840c5","partyId":"eef5f5aa729d102ecf6ca6e9b21ed4adea40b97f427cc7c2a9c3335e671a4dff","orderIds":["96c1a08e0828f7becee080a027d56bd858f52f9361f72a1bd485f695a0b2c56f"]},"version":1,"chainId":"testnet-001","txHash":"5695CEB0114E7236ACF9240F71E293E00C46AFAC5E5775E7FE45098944F47DBA"}

@EVODelavega EVODelavega merged commit 4d001a6 into develop May 14, 2024
15 checks passed
@EVODelavega EVODelavega deleted the order-cancellation-cache branch May 14, 2024 11:51
jeremyletang pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants