feat: add heartbeat to eth-forwarder so last-seen block heights stay … #11411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwestgarth
force-pushed
the
11334-forwarder-heartbeat
branch
5 times, most recently
from
e817e7e
to
8e364da
Compare
wwestgarth
force-pushed
the
11334-forwarder-heartbeat
branch
from
8e364da
to
cbd93d1
Compare
candida-d
reviewed
Jun 26, 2024
wwestgarth
force-pushed
the
11334-forwarder-heartbeat
branch
3 times, most recently
from
05a3091
to
aa251fc
Compare
candida-d
previously approved these changes
Jun 27, 2024
wwestgarth
force-pushed
the
11334-forwarder-heartbeat
branch
from
aa251fc
to
a4ac5fb
Compare
candida-d
approved these changes
Jul 2, 2024
wwestgarth
force-pushed
the
11334-forwarder-heartbeat
branch
from
c3d0700
to
d62b87c
Compare
jeremyletang
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11334
The Ethereum event forwarder will now send out a "heartbeat" chain event if no event-logs are seen on a contract for over an hour (configurable). This is so that the "last-seen" block saved into the snapshot remains relatively up to date so that after a protocol upgrade fewer block-spans need to be rechecked.
Other changes worth noting:
evtforwardpackage, instead of being dotted around each individual engine that processes a chain event.block-timefield to theEthereumConfignetwork parameter, like we have in theEVMConfigparameter, so core is aware of the expected block duration on Ethereum.