fix: do not enter long block auction if market is terminated #11424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the protocol-upgrade block on stagnet1, there was a market that is in a terminated state. After the protocol upgrade the new long block auction code was kicking all markets into an auction, including this terminated one. The result was that eventually the market became active again.
This caused an inconsistency when restoring from a later snapshot since this now active market would be restored as active, but its time-trigger data-source would immediately terminate it again. On the "normal-node" the time-trigger data-source had been unsubscribed and so stayed active. This difference caused the restored node to fall out of consensus.