-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1974 market framework #2013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVODelavega
force-pushed
the
feature/1974-market-framework
branch
from
July 22, 2020 12:32
38b333b
to
510cf6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a bunch of convert functions will be missing in the graphql package for the fields / message you introduced in proto.
Could you label the ticket this closes in the description? |
Nice docs work in this PR 👍 |
edd
reviewed
Jul 24, 2020
EVODelavega
force-pushed
the
feature/1974-market-framework
branch
from
July 27, 2020 13:19
efe52ea
to
1d619b3
Compare
system-tests failed.
|
jeremyletang
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1974 Adding opening auction definition to the market framework.
Changes to market framework and some parts of the API:
Market data will have 2 additional fields, and a new market proposal gets a new field, too.
These fields currently aren't required, to make it easier on everyone to make the required changes