Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1974 market framework #2013

Merged
merged 5 commits into from
Jul 27, 2020
Merged

Conversation

EVODelavega
Copy link
Contributor

@EVODelavega EVODelavega commented Jul 22, 2020

Closes #1974 Adding opening auction definition to the market framework.

Changes to market framework and some parts of the API:

Market data will have 2 additional fields, and a new market proposal gets a new field, too.

These fields currently aren't required, to make it easier on everyone to make the required changes

@EVODelavega EVODelavega force-pushed the feature/1974-market-framework branch from 38b333b to 510cf6f Compare July 22, 2020 12:32
Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bunch of convert functions will be missing in the graphql package for the fields / message you introduced in proto.

gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
gateway/graphql/schema.graphql Show resolved Hide resolved
gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
proto/markets.proto Show resolved Hide resolved
@edd
Copy link
Member

edd commented Jul 22, 2020

Could you label the ticket this closes in the description?

@edd
Copy link
Member

edd commented Jul 22, 2020

Nice docs work in this PR 👍

@EVODelavega EVODelavega force-pushed the feature/1974-market-framework branch from efe52ea to 1d619b3 Compare July 27, 2020 13:19
@EVODelavega EVODelavega marked this pull request as ready for review July 27, 2020 13:36
@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/devnet/sanityTests.py ......                           [100%]
../../grpcTesting/governance/newMarketGovTests.py EEEEEEEEEEEEEEEEEEEEEx [ 47%]
EEEEEEEEEEEEEEEEEEEEEEEE                                                 [100%]
 ERROR at setup of testVoteNDecline 
 ERROR at setup of testVoteYEnactedFail 
 ERROR at setup of testVoteYNProposalDraw 
 ERROR at setup of testVoteYYNProposalPass 
 ERROR at setup of testNewMarketRejectNoStake 
 ERROR at setup of testNewMarketValidProposal 
 ERROR at setup of testGetAllProposals 
 ERROR at setup of testGetAllOfTheProposals[6] 
 ERROR at setup of testGetNewMarketProposals[6] 
 ERROR at setup of testGetAllOfTheProposals[2] 
 ERROR at setup of testGetNewMarketProposals[2] 
 ERROR at setup of testGetAllOfTheProposals[5] 
 ERROR at setup of testGetNewMarketProposals[5] 
 ERROR at setup of testGetAllOfTheProposals[4] 
 ERROR at setup of testGetNewMarketProposals[4] 
 ERROR at setup of testGetAllOfTheProposals[3] 
 ERROR at setup of testGetNewMarketProposals[3] 
 ERROR at setup of testGetProposalsByParty 
 ERROR at setup of testGetRejectedProposalsByParty 
 ERROR at setup of testGetOpenProposalsByParty 
 ERROR at setup of testGetVotesByParty 
 ERROR at setup of testNewMarketOpenSingleTok 
 ERROR at setup of testVoteYSmallHolder 
 ERROR at setup of testVoteYMediumNSmallHolder 
 ERROR at setup of testVoteTopUpSmallDuringVote 
 ERROR at setup of testVoteYNNoFundsProposal 
 ERROR at setup of testNewMarketInvalidParty 
 ERROR at setup of testInvalidEnactTime 
 ERROR at setup of testVoteYOwnOpenProposal 
 ERROR at setup of testVoteYOpenProposal 
 ERROR at setup of testVoteNOpenProposal 
 ERROR at setup of testVoteNoStakeOpenProposal 
 ERROR at setup of testVoteNoStakeAddFunds 
 ERROR at setup of testVoteRejectProposal 
 ERROR at setup of testVotePassedProposal 
 ERROR at setup of testVoteBothYNOpen 
 ERROR at setup of testVoteTwiceYSameUser 
 ERROR at setup of testVoteInvalidProposalID 
 ERROR at setup of testVoteEnactedMarket 
 ERROR at setup of testVoteDeclinedMarket 
 ERROR at setup of testVoteYTaintedKey 
 ERROR at setup of testNewMarketClosedProposal 
 ERROR at setup of testSubmitEnactedGTCOrder 
 ERROR at setup of testSubmitUnEnactedMarketGTCOrder 
 ERROR at setup of testFiftyYesVoteProposal 
../../grpcTesting/governance/newMarketTradesTests.py ......FF.F..        [100%]
 testCloseOutTraderBuyOrders 
 testCloseOutTraderSellOrders 
 testTradeGTTToIOC 
../../grpcTesting/margins/marginsTests.py ..                             [100%]
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/amendOrdersTests.py ........................... [ 87%]
....                                                                     [100%]
../../grpcTesting/orders/cancelOrdersTests.py .......................    [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/limitOrdersTests.py ...........                 [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/mixedOrdersTests.py .....................       [100%]
../../grpcTesting/orders/negativeOrdersTests.py ........................ [ 57%]
....x.........s...                                                       [100%]
../../grpcTesting/parallel/submitParallelOrdersTests.py ........         [100%]
../../grpcTesting/parties/partiesTests.py ..                             [100%]
../../grpcTesting/trading/positionsTests.py ..                           [100%]
../../grpcTesting/trading/tradesTests.py ......FF.F..                    [100%]
 testCloseOutTraderBuyOrders 
 testCloseOutTraderSellOrders 
 testTradeGTTToIOC 
../../grpcTesting/wallet/walletTests.py ................................ [ 76%]
..........                                                               [100%]
../../rest/orders/negativeOrdersTests.py .                               [100%]

@jeremyletang jeremyletang merged commit 82067ba into develop Jul 27, 2020
@edd edd mentioned this pull request Aug 10, 2020
12 tasks
@ashleyvega ashleyvega deleted the feature/1974-market-framework branch November 5, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add opening auction parameter to market framework
4 participants