Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set keep alive retry for gql #2034

Merged
merged 1 commit into from
Jul 27, 2020
Merged

set keep alive retry for gql #2034

merged 1 commit into from
Jul 27, 2020

Conversation

jeremyletang
Copy link
Member

No description provided.

@jeremyletang jeremyletang requested review from edd and a team July 27, 2020 12:43
edd
edd approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@edd edd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this is the cause of https://github.com/vegaprotocol/console/issues/3844 so 🤞

@jeremyletang
Copy link
Member Author

Thanks. I think this is the cause of vegaprotocol/console#3844 so 🤞

Well I think you are blaming core, for console issue...

@edd
Copy link
Member

edd commented Jul 27, 2020

Well I think you are blaming core, for console issue...

It's fine, I'm blaming Apollo. My hunch is that in all the reconnecting mess, we're missing updates we actually care about.

The problem is that when Apollo reconnects due to not receiving a keepalive, it doesn't reset it's timeout. So as soon as it reconnects, it thinks it hasn't received a keepAlive for timeout and immediately closes the connection and reconnects. 🤦

@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/governance/newMarketGovTests.py EEEEEEEEEEEEEEEEEEEEEx [ 47%]
EEEEEEEEEEEEEEEEEEEEEEEE                                                 [100%]
 ERROR at setup of testVoteNDecline 
 ERROR at setup of testVoteYEnactedFail 
 ERROR at setup of testVoteYNProposalDraw 
 ERROR at setup of testVoteYYNProposalPass 
 ERROR at setup of testNewMarketRejectNoStake 
 ERROR at setup of testNewMarketValidProposal 
 ERROR at setup of testGetAllProposals 
 ERROR at setup of testGetAllOfTheProposals[6] 
 ERROR at setup of testGetNewMarketProposals[6] 
 ERROR at setup of testGetAllOfTheProposals[2] 
 ERROR at setup of testGetNewMarketProposals[2] 
 ERROR at setup of testGetAllOfTheProposals[5] 
 ERROR at setup of testGetNewMarketProposals[5] 
 ERROR at setup of testGetAllOfTheProposals[4] 
 ERROR at setup of testGetNewMarketProposals[4] 
 ERROR at setup of testGetAllOfTheProposals[3] 
 ERROR at setup of testGetNewMarketProposals[3] 
 ERROR at setup of testGetProposalsByParty 
 ERROR at setup of testGetRejectedProposalsByParty 
 ERROR at setup of testGetOpenProposalsByParty 
 ERROR at setup of testGetVotesByParty 
 ERROR at setup of testNewMarketOpenSingleTok 
 ERROR at setup of testVoteYSmallHolder 
 ERROR at setup of testVoteYMediumNSmallHolder 
 ERROR at setup of testVoteTopUpSmallDuringVote 
 ERROR at setup of testVoteYNNoFundsProposal 
 ERROR at setup of testNewMarketInvalidParty 
 ERROR at setup of testInvalidEnactTime 
 ERROR at setup of testVoteYOwnOpenProposal 
 ERROR at setup of testVoteYOpenProposal 
 ERROR at setup of testVoteNOpenProposal 
 ERROR at setup of testVoteNoStakeOpenProposal 
 ERROR at setup of testVoteNoStakeAddFunds 
 ERROR at setup of testVoteRejectProposal 
 ERROR at setup of testVotePassedProposal 
 ERROR at setup of testVoteBothYNOpen 
 ERROR at setup of testVoteTwiceYSameUser 
 ERROR at setup of testVoteInvalidProposalID 
 ERROR at setup of testVoteEnactedMarket 
 ERROR at setup of testVoteDeclinedMarket 
 ERROR at setup of testVoteYTaintedKey 
 ERROR at setup of testNewMarketClosedProposal 
 ERROR at setup of testSubmitEnactedGTCOrder 
 ERROR at setup of testSubmitUnEnactedMarketGTCOrder 
 ERROR at setup of testFiftyYesVoteProposal 
../../grpcTesting/governance/newMarketTradesTests.py EEEEEEEEEEEE        [100%]
 ERROR at setup of testTradeGTCToGTC 
 ERROR at setup of testTradeGTTToGTT 
 ERROR at setup of testTradeGTCToIOC 
 ERROR at setup of testTradeGTCToFOK 
 ERROR at setup of testTradesByParty 
 ERROR at setup of testPositionsByParty 
 ERROR at setup of testCloseOutTraderBuyOrders 
 ERROR at setup of testCloseOutTraderSellOrders 
 ERROR at setup of testTradesByMarket 
 ERROR at setup of testTradeGTTToIOC 
 ERROR at setup of testTradeGTTToFOK 
 ERROR at setup of testNoTradeGTCToStopped 
../../grpcTesting/margins/marginsTests.py F.                             [100%]
 testMarginLevelStoppedFOK 
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/amendOrdersTests.py ........................... [ 87%]
....                                                                     [100%]
../../grpcTesting/orders/cancelOrdersTests.py .......................    [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/mixedOrdersTests.py .....................       [100%]
../../grpcTesting/orders/negativeOrdersTests.py ........................ [ 57%]
....x.........s...                                                       [100%]
../../grpcTesting/parallel/submitParallelOrdersTests.py ........         [100%]
../../grpcTesting/parties/partiesTests.py ..                             [100%]
../../grpcTesting/trading/positionsTests.py ..                           [100%]
../../grpcTesting/trading/tradesTests.py ......FF....                    [100%]
 testCloseOutTraderBuyOrders 
 testCloseOutTraderSellOrders 
../../grpcTesting/wallet/walletTests.py ................................ [ 76%]
..........                                                               [100%]
../../rest/orders/negativeOrdersTests.py .                               [100%]

@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/governance/newMarketGovTests.py .....................x [ 47%]
.FFF....................                                                 [100%]
 testVoteYSmallHolder 
 testVoteYMediumNSmallHolder 
 testVoteTopUpSmallDuringVote 
../../grpcTesting/governance/newMarketTradesTests.py EEEEEEEEEEEE        [100%]
 ERROR at setup of testTradeGTCToGTC 
 ERROR at setup of testTradeGTTToGTT 
 ERROR at setup of testTradeGTCToIOC 
 ERROR at setup of testTradeGTCToFOK 
 ERROR at setup of testTradesByParty 
 ERROR at setup of testPositionsByParty 
 ERROR at setup of testCloseOutTraderBuyOrders 
 ERROR at setup of testCloseOutTraderSellOrders 
 ERROR at setup of testTradesByMarket 
 ERROR at setup of testTradeGTTToIOC 
 ERROR at setup of testTradeGTTToFOK 
 ERROR at setup of testNoTradeGTCToStopped 
../../grpcTesting/margins/marginsTests.py ..                             [100%]
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/amendOrdersTests.py ........................... [ 87%]
....                                                                     [100%]
../../grpcTesting/orders/cancelOrdersTests.py .......................    [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/limitOrdersTests.py ...........                 [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/mixedOrdersTests.py .....................       [100%]
../../grpcTesting/orders/negativeOrdersTests.py ........................ [ 57%]
....x.........s...                                                       [100%]
../../grpcTesting/parallel/submitParallelOrdersTests.py ........         [100%]
../../grpcTesting/parties/partiesTests.py ..                             [100%]
../../grpcTesting/trading/positionsTests.py ..                           [100%]
../../grpcTesting/trading/tradesTests.py ......FF.F..                    [100%]
 testCloseOutTraderBuyOrders 
 testCloseOutTraderSellOrders 
 testTradeGTTToIOC 
../../grpcTesting/wallet/walletTests.py ................................ [ 76%]
..........                                                               [100%]
../../rest/orders/negativeOrdersTests.py .                               [100%]

@edd edd merged commit db5edbe into develop Jul 27, 2020
@ashleyvega ashleyvega deleted the feature/gqlgen-add-keepAliveRetry branch July 27, 2020 16:18
@edd edd mentioned this pull request Aug 10, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edd edd edd approved these changes

@peterbarrow peterbarrow peterbarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeremyletang @edd @vega-ci-bot @peterbarrow