Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network order with Active status #2061

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

jeremyletang
Copy link
Member

We had an issue where network order where not fully matched (matched up to the average price)
We now make the NETWORK order behave as a MARKET order, and set the average price at the end of uncrossing.

closes #2060

network order uncrossing behave like market order
@jeremyletang jeremyletang requested review from edd, peterbarrow and a team August 4, 2020 08:04
@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/governance/newAssetTests.py .                          [100%]
../../grpcTesting/governance/newMarketGovTests.py .....................x [ 47%]
........................                                                 [100%]
../../grpcTesting/governance/newMarketTradesTests.py ............        [100%]
../../grpcTesting/margins/marginsTests.py F.                             [100%]
 testMarginLevelStoppedFOK 
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/amendOrdersTests.py ........................... [ 87%]
....                                                                     [100%]
../../grpcTesting/orders/cancelOrdersTests.py .......................    [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/limitOrdersTests.py ...........                 [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/mixedOrdersTests.py .....................       [100%]
../../grpcTesting/orders/negativeOrdersTests.py ........................ [ 57%]
....x.........s...                                                       [100%]
../../grpcTesting/parallel/submitParallelOrdersTests.py ........         [100%]
../../grpcTesting/parties/partiesTests.py ..                             [100%]
../../grpcTesting/trading/positionsTests.py ..                           [100%]
../../grpcTesting/trading/tradesTests.py ............                    [100%]
../../grpcTesting/wallet/walletTests.py ................................ [ 91%]
...                                                                      [100%]
../../rest/orders/negativeOrdersTests.py .                               [100%]

@jeremyletang jeremyletang merged commit f7d37ac into develop Aug 4, 2020
@jeremyletang jeremyletang deleted the bugfix/2060-network-order-activd branch August 4, 2020 13:47
@edd edd mentioned this pull request Aug 10, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network order may be Active in some cases
4 participants