Bugfix/2103 stop withdrawal if amount too big

[jeremyletang]

Add a LockFund step to be used later which ensure we have enough funds to withdraw.
return an error if cannot or process.
closes #2103

[edd]

The withdraw lock account seems like a good approach. I guess it'll need a timeout or something so funds don't get stuck there forever?

[jeremyletang]

The withdraw lock account seems like a good approach. I guess it'll need a timeout or something so funds don't get stuck there forever?

Absolutely, it's mentionned in the ticket for the withdrawal of erc20 that we want to have a timeout on that. Initial version won't have this, and we'll take care of it later. I prefer to finalize the whole withdrawal before introduce the timeout mecanics.

[edd]

@jeremyletang Great - I've put a ticket on https://github.com/orgs/vegaprotocol/projects/24#card-44024089 so we don't forget about that

[jeremyletang]

This has been rebased + integration tests fixed and is therefore ready to merge.

[vega-ci-bot]

system-tests failed.

=== Test summary ===
../../grpcTesting/governance/newAssetTests.py ..F......x............x.ss [ 89%]
sss                                                                      [100%]
 testDepositBuiltInAmtGreatMaxDep 
../../grpcTesting/governance/newMarketGovTests.py .....................x [ 47%]
........................                                                 [100%]
../../grpcTesting/governance/newMarketTradesTests.py ............        [100%]
../../grpcTesting/margins/marginsTests.py x..x                           [100%]
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/amendOrdersTests.py .ssssssssssssssssssssssssss [ 81%]
ssssss                                                                   [100%]
../../grpcTesting/orders/cancelOrdersTests.py .....................s.s   [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/limitOrdersTests.py ............                [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/mixedOrdersTests.py ..................sss       [100%]
../../grpcTesting/orders/negativeOrdersTests.py ........................ [ 57%]
....x..ssssss.s...                                                       [100%]
../../grpcTesting/parallel/submitParallelOrdersTests.py ......s.         [100%]
../../grpcTesting/parties/partiesTests.py ..                             [100%]
../../grpcTesting/trading/positionsTests.py ..                           [100%]
../../grpcTesting/trading/tradesTests.py FF............                  [100%]
 testCheckFeesAggresiveSell 
 testCheckFeesAggresiveBuy 
../../grpcTesting/wallet/walletTests.py ................................ [ 91%]
.s.                                                                      [100%]
../../rest/orders/negativeOrdersTests.py .                               [100%]