Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add subscription that is not an all-event sub #2151

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

EVODelavega
Copy link
Contributor

@EVODelavega EVODelavega commented Aug 27, 2020

Rather than sending events in their own channel (which as causing several events of the same time being queued up in their own routine, and being sent out of order), the broker now maintains a channel per event type internally, and uses that to send out events to their respective subscribers in order

@edd
Copy link
Member

edd commented Aug 27, 2020

@EVODelavega is there a way that we can test that this specific change is good, or is the best option we have to verify that it fixes #2139?

@jeremyletang
Copy link
Member

@EVODelavega is there a way that we can test that this specific change is good, or is the best option we have to verify that it fixes #2139?

For what it's worth I ran it locally and tried to get the accounts, see if ordering was respected. and it was all fine.

@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/governance/newAssetTests.py ....                       [100%]
../../grpcTesting/markets/marketsTests.py ..............                 [100%]
../../grpcTesting/orders/cancelOrdersTests.py ...                        [100%]
../../grpcTesting/orders/generalOrdersTests.py .............             [100%]
../../grpcTesting/orders/limitOrdersTests.py .......                     [100%]
../../grpcTesting/orders/marketOrdersTests.py ........                   [100%]
../../grpcTesting/orders/negativeOrdersTests.py ...........              [100%]
../../grpcTesting/trading/positionsTests.py .                            [100%]
../../grpcTesting/trading/tradesTests.py .......                         [100%]

@EVODelavega EVODelavega merged commit 91fc175 into develop Aug 27, 2020
@EVODelavega EVODelavega deleted the hotfix/preserve-event-order branch August 27, 2020 13:53
@ashleyvega ashleyvega restored the hotfix/preserve-event-order branch August 28, 2020 08:15
ashleyvega added a commit that referenced this pull request Aug 28, 2020
…ent-order"

This reverts commit 91fc175, reversing
changes made to bda4f18.
ashleyvega added a commit that referenced this pull request Aug 28, 2020
Revert "Merge pull request #2151 from vegaprotocol/hotfix/preserve-event-order"
@edd edd mentioned this pull request Sep 1, 2020
10 tasks
@ashleyvega ashleyvega deleted the hotfix/preserve-event-order branch November 5, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants