-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory usage for event ordering changes #2167
Conversation
78dcac5
to
700a0c7
Compare
Only system tests are failing here. should we move forward? |
@jeremyletang Not sure why they're failing. I'll try to trigger the build again, but otherwise I think it's best to proceed. Preserving event order addresses a number of issues. |
From what @ashleyvega said it's normal that system test would fail for a while. just go ahead merging. |
PR description, please @EVODelavega. |
system-tests failed.
|
Remove the
tSubSlice
map, which caused the race detector to complain, and was possibly the cause of a memory leak (unregistered subscribers for streams not being removed properly, and aggregating data that was never consumed).