Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure margin accounts funds are release each time a position goes back completely to 0. #2239

Merged
merged 1 commit into from
Sep 15, 2020
Merged

ensure margin accounts funds are release each time a position goes back completely to 0. #2239

merged 1 commit into from
Sep 15, 2020

Conversation

jeremyletang
Copy link
Member

closes #2069
closes #2065
closes #2145

@jeremyletang jeremyletang requested review from ponthief and a team September 13, 2020 14:32
@jeremyletang jeremyletang self-assigned this Sep 13, 2020
@edd edd mentioned this pull request Sep 14, 2020
Closed
19 tasks
ponthief
ponthief reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ponthief ponthief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have specific tests...will confirm once merged

ponthief
ponthief approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@ponthief ponthief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that integration tests are written..will verify with the system-tests

@ponthief ponthief merged commit fae69a1 into develop Sep 15, 2020
@ashleyvega ashleyvega deleted the feature/check-for-funds-to-release branch November 5, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponthief ponthief ponthief approved these changes

Assignees

@jeremyletang jeremyletang

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jeremyletang @ponthief