Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various wash trade fixes. #2262

Merged
merged 2 commits into from
Sep 17, 2020
Merged

various wash trade fixes. #2262

merged 2 commits into from
Sep 17, 2020

Conversation

jeremyletang
Copy link
Member

  1. orderbook.GetTrade() return the trade in case of wash trade
  2. ensure market clear the potential positions after a wash trade

@jeremyletang
orderbook.GetTrade() return the trade in case of wash trade
4a260b2 
ensure market clear the potential positions after a wash trade
@jeremyletang jeremyletang requested review from ponthief and a team September 16, 2020 13:24
ponthief
ponthief approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ponthief ponthief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conducted testing on this branch and tests have passed

@ponthief ponthief merged commit b0849cd into develop Sep 17, 2020
@edd edd mentioned this pull request Sep 22, 2020
Closed
19 tasks
@ashleyvega ashleyvega deleted the bugfix/make-sure-wash-trade-order-get-potential-position-released branch November 5, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EVODelavega EVODelavega EVODelavega approved these changes

@ponthief ponthief ponthief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremyletang @EVODelavega @ponthief