Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed auction uncrossing #2281

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fixed auction uncrossing #2281

merged 1 commit into from
Sep 22, 2020

Conversation

peterbarrow
Copy link
Contributor

After all the parts of the auction code were merged there were some missing pipework to link it all together:

  1. Orders that are filled are now marked as filled
  2. All orders and impacted orders create an eventbus event
  3. Debug testing code removed to allow uncrossing to take place.

Closes #2280

@peterbarrow peterbarrow self-assigned this Sep 22, 2020
@peterbarrow peterbarrow marked this pull request as ready for review September 22, 2020 09:27
@edd edd mentioned this pull request Sep 22, 2020
Closed
19 tasks
@peterbarrow peterbarrow merged commit 0a7aa57 into develop Sep 22, 2020
@peterbarrow peterbarrow deleted the 2280-fix-opening-auction-uncrossing branch September 22, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees

@peterbarrow peterbarrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening auction not uncrossing
2 participants
@peterbarrow @jeremyletang