fix typo in proto PriceMonitoringSettings -> priceMonitoringSettings #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DomVega Would you be able to confirm that you this issue is now fixed before we merge? |
|
Checking now |
|
@jeremyletang I've ran a test on my local env and seemed to work, although I'd like to have a double check done by @davidsiska-vega just for the sake of safety |
Thanks @DomVega I think we discussed that with @davidsiska-vega and it was a typo in the name, and it should be fine now. |
qustavo
approved these changes
Nov 30, 2020
EVODelavega
approved these changes
Nov 30, 2020
qustavo
deleted the
feature/2646-governance-parameter-does-not-set-price-monitoring-params
branch
jeremyletang
pushed a commit
that referenced
this pull request
Dec 3, 2020
…rameter-does-not-set-price-monitoring-params fix typo in proto PriceMonitoringSettings -> priceMonitoringSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An proto field was name with a capital, which was generating a json field with a capital as well, which is not what was expected.
This should fix it.
close #2646