Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove order created at bug #2705

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

peterbarrow
Copy link
Contributor

@peterbarrow peterbarrow commented Dec 4, 2020

We found an error where orders that had lost their time priority could not be deleted from the order book because the code expected the orders on a price level to be sorted by createdAt. This sorting can be broken by amends and pegged orders so this code was failing to remove orders.

We now iterate through all the orders on a price level ignoring the createdAt field.

@jeremyletang jeremyletang merged commit 9a8be0e into develop Dec 4, 2020
@peterbarrow peterbarrow deleted the 2599-fix-remove-order-createdAt-bug branch December 4, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants