Update Transfers to use only unsigned uint64 #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed collateral engine
update risk engine and collateral
jeremyletang
force-pushed
the
feature/3128-financial-amount-int64-to-uint64
branch
from
a5f3c9d
to
3113e4f
Compare
EVODelavega
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just occured to me that we need to do this before moving to the big uint. The code is now expecting in some places negative amount (legacy) for e.g: mtm losses.
The code doing that will be uncompatible with the big uints, it is mandatory to implement this now, so we do not introduce both the move to an unsigned integer and a new type in the same changes.
This is done in order to prepare for the move to big uint.
close #3128