reuse same IDs with LP orders #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed this one with @edd to get an understanding on how this would impact the console, and it appears that should not be so much of an issue. I'd suggest we get on with it, and see on develop if anything get broken. |
peterbarrow
approved these changes
Apr 12, 2021
jeremyletang
force-pushed
the
feature/immutable-lp-order-ids
branch
from
71bb01d
to
e7520b1
Compare
|
@jeremyletang can this be merged? |
|
That should be fine. Would be good maybe if @3jtechtest sanity check test it. |
Closed
jeremyletang
force-pushed
the
feature/immutable-lp-order-ids
branch
from
e7520b1
to
1ec7fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change slightly the behaviour of Lp orders.
They are still being cancelled, and re-created, but now using the same IDs all the time.
closes #3340