Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging for party without accounts (#3287) #3341

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

peterbarrow
Copy link
Contributor

When a transaction is sent but the party has no accounts we log a message so we can capture the error.

@peterbarrow peterbarrow requested a review from a team April 12, 2021 14:31
@ashleyvega
Copy link
Contributor

@peterbarrow Would it be helpful to log what type of tx is being attempted?

@peterbarrow peterbarrow marked this pull request as ready for review April 12, 2021 14:32
@peterbarrow
Copy link
Contributor Author

@peterbarrow Would it be helpful to log what type of tx is being attempted?

@ashleyvega I've added the command string to the log statement, is this what you mean?

2021-04-12T16:36:38.525Z ERROR processor processor/abci.go:290 Rejected as party has no accounts {"PubKey": "6c2cd9ea8a29f0c6ca558f75164ebda9c39aa3b69d7fa9fdd7def196d148fb3a", "Command": "Submit Order"}

Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, don’t matter much

processor/abci.go Outdated Show resolved Hide resolved
@jeremyletang jeremyletang merged commit 1da37da into develop Apr 14, 2021
@jeremyletang jeremyletang deleted the 3287-adding-logging-for-rejected-transactions branch April 14, 2021 10:23
@edd edd mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants