Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on lp order deployment #3369

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Conversation

jeremyletang
Copy link
Member

  • Ensure all amends and create are being returned
  • do not try to evaluate liquidity when submitting / cancelling an LP.

It fixes one thing: The order generated by liquidity where not done properly, but it was working, because we were re-validationg liquidity recursively when submitting / cancelling liquidity order.

so what was happeningwas:

  • the engine was returning theorder to cancels
  • the market was cancelling the orders
  • by cancelling the order liquidity checks were triggered
  • the liquidity check was re-creatingthe order as it was cancelled.
    Now the cancellation do not trigger a new liquidity check (which may be the cause of the panic)
    But the orders are properly cancelled / created thanks to the fix in the liquidity engine.

- Ensure all amends and create are being returned
- do not try to evaluate liquidity when submitting / cancelling an LP.
@jeremyletang jeremyletang merged commit a4ef68f into develop Apr 16, 2021
@edd edd mentioned this pull request Apr 20, 2021
@jeremyletang jeremyletang deleted the bugfix/panic-unregister-orderf branch July 13, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants