Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank oracle spec ids #3419

Merged
merged 4 commits into from Apr 26, 2021
Merged

Fix blank oracle spec ids #3419

merged 4 commits into from Apr 26, 2021

Conversation

ValentinTrinque
Copy link
Contributor

Closes #3353

@ValentinTrinque ValentinTrinque self-assigned this Apr 26, 2021
@jeremyletang jeremyletang marked this pull request as ready for review April 26, 2021 17:06
jeremyletang
jeremyletang approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS GOOD TO ME.

@ValentinTrinque ValentinTrinque force-pushed the feature/3353-blank-oracle-spec-id branch from 4f8335b to 3ed9e74 Compare April 26, 2021 17:09
jeremyletang
jeremyletang requested changes Apr 26, 2021
View reviewed changes
oracles/oracle_spec.go Outdated Show resolved Hide resolved
@jeremyletang jeremyletang merged commit 3765850 into develop Apr 26, 2021
@jeremyletang jeremyletang deleted the feature/3353-blank-oracle-spec-id branch April 26, 2021 17:35
@edd edd mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees

@ValentinTrinque ValentinTrinque

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle spec IDs are blank on testnet / devnet
2 participants
@ValentinTrinque @jeremyletang