Reject non-persistent orders in case they exceed price bounds #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVODelavega
force-pushed
the
feature/3362-no-pm-for-FOK
branch
from
72ebfa9
to
d318f65
Compare
|
GraphQL side of this looks good to me |
EVODelavega
force-pushed
the
feature/3362-no-pm-for-FOK
branch
2 times, most recently
from
864cd8b
to
cc60055
Compare
…ned by the bounds that were breached
…o STOPPED, add integration test to replace system test
EVODelavega
force-pushed
the
feature/3362-no-pm-for-FOK
branch
from
62d631c
to
01f01a3
Compare
jeremyletang
approved these changes
May 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the integration tests have been updated, others have been updated to ensure that IOC/FOK/GFN orders can't trigger price auctions.