Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proposal submission command #3436

Merged
merged 5 commits into from Apr 30, 2021

Conversation

jeremyletang
Copy link
Member

This introduce a ProposalSubmission command instead of using the Proposal type in the command. This is a first step to separate properly our Command to submit a new proposal, and our proposal model.

Here's the difference between both data structures:

message ProposalSubmission {
  string reference = 1;
  ProposalTerms terms = 2 [(validator.field) = {msg_exists: true}];
}

message Proposal {
  enum State {
    // all enum state fields
  }

  string id = 1;
  string reference = 2;
  string party_id = 3 [(validator.field) = {string_not_empty : true}];
  State state = 4 [(validator.field) = {is_in_enum: true}];
  int64 timestamp = 5;
  ProposalTerms terms = 6 [(validator.field) = {msg_exists: true}];
  ProposalError reason = 7;
}

@jeremyletang jeremyletang requested review from a team and edd April 29, 2021 18:01
Copy link
Contributor

@ashleyvega ashleyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashleyvega
Copy link
Contributor

Let's get this merged before v0.36.0, so all the API changes (votes, events, proposals) happen at once.

@jeremyletang
Copy link
Member Author

Let's get this merged before v0.36.0, so all the API changes (votes, events, proposals) happen at once.

That’s my intent to get all these done as soon as possible

@jeremyletang jeremyletang merged commit 99e77fc into develop Apr 30, 2021
@jeremyletang jeremyletang deleted the feature/proposal-submission-command branch April 30, 2021 08:36
@edd edd mentioned this pull request May 11, 2021
ashleyvega pushed a commit that referenced this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants