Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all vega commands into a commands subfolder / package in the proto package #3438

Merged
merged 9 commits into from May 1, 2021

Conversation

jeremyletang
Copy link
Member

This move all commands into a commands subfolder in the proto pacakge.

@jeremyletang jeremyletang requested a review from a team April 30, 2021 08:55
@jeremyletang jeremyletang changed the title Feature/command proto package Move all vega commands into a commands subfolder / package in the proto packaeg Apr 30, 2021
@jeremyletang jeremyletang changed the title Move all vega commands into a commands subfolder / package in the proto packaeg Move all vega commands into a commands subfolder / package in the proto package Apr 30, 2021
Copy link
Contributor

@ashleyvega ashleyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plus one comment

proto/vega_ext.go Outdated Show resolved Hide resolved
@jeremyletang
Copy link
Member Author

Do not get that merge straight away though. I'm still doing some work on this + needs to update system-tests.

@jeremyletang jeremyletang marked this pull request as ready for review May 1, 2021 08:16
@jeremyletang jeremyletang merged commit 6d1ad2f into develop May 1, 2021
@jeremyletang jeremyletang deleted the feature/command-proto-package branch May 1, 2021 08:34
@edd edd mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants