Clean up the order submission #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinTrinque
force-pushed
the
feature/3441-cleanup-order-submission
branch
from
7ef6416
to
0d25b1b
Compare
ValentinTrinque
force-pushed
the
feature/3441-cleanup-order-submission
branch
from
0d25b1b
to
ea0ad7d
Compare
jeremyletang
reviewed
May 1, 2021
There was a problem hiding this comment.
A few comments to address here.
Also after a disussion with @mattrussell36l, what you suggested in this issue: #3448, is OK for the frontend, so let's add the changes in this PR so you can cleanly implement passing the submission down to the Market.
ValentinTrinque
force-pushed
the
feature/3441-cleanup-order-submission
branch
3 times, most recently
from
6c1adc0
to
c78bf7d
Compare
ValentinTrinque
force-pushed
the
feature/3441-cleanup-order-submission
branch
from
6d93628
to
a2c7c27
Compare
ValentinTrinque
force-pushed
the
feature/3441-cleanup-order-submission
branch
from
a2c7c27
to
54f4b2e
Compare
jeremyletang
approved these changes
May 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3441
Closes #3448