Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the LP implementation #3452

Merged
merged 3 commits into from May 4, 2021
Merged

Cleanup the LP implementation #3452

merged 3 commits into from May 4, 2021

Conversation

jeremyletang
Copy link
Member

@jeremyletang jeremyletang commented May 3, 2021 •
edited

Cleanup some bits and pieces of the LP implementation

Couples of cleanup and simplification for the LPs:

  • handle create/amend/delete more explicitly
  • remove the killAll logic when creating LP as it's unnecessary (if we create an LP there should be no existing orders)
  • move all LP related stuff in execution engine in a specific file

@jeremyletang jeremyletang marked this pull request as draft May 3, 2021 18:51
@jeremyletang jeremyletang changed the title Feature/cleanup lp Cleanup the LP implementation May 4, 2021
@jeremyletang jeremyletang requested a review from a team May 4, 2021 07:32
@jeremyletang jeremyletang marked this pull request as ready for review May 4, 2021 07:32
@jeremyletang jeremyletang merged commit 85c445b into develop May 4, 2021
@jeremyletang jeremyletang deleted the feature/cleanup-lp branch May 4, 2021 11:45
@edd edd mentioned this pull request May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarrow peterbarrow peterbarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremyletang @peterbarrow