disable rate limiting + change balance check to check if party ever deposited not if they still have funds. #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyvega
reviewed
May 11, 2021
ashleyvega
reviewed
May 11, 2021
jeremyletang
force-pushed
the
hotfix/fix-balance-checks
branch
from
4da6537
to
f84ad2b
Compare
…eposited not if they still have funds.
jeremyletang
force-pushed
the
hotfix/fix-balance-checks
branch
from
f84ad2b
to
6a53c35
Compare
peterbarrow
approved these changes
May 11, 2021
jeremyletang
added a commit
that referenced
this pull request
May 11, 2021
disable rate limiting + change balance check to check if party ever deposited not if they still have funds.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the rate limiting for now + change how the balance check happen.
Once merged, we'll need to cherry pick that to make it a patch for testnet.
Also do not merged until @peterbarrow approval, is gonna load test it on his locally machine to make sure we are OK.