Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From uint64 to uint256 (main branch) #3569

Merged
merged 219 commits into from Jul 2, 2021
Merged

From uint64 to uint256 (main branch) #3569

merged 219 commits into from Jul 2, 2021

Conversation

jeremyletang
Copy link
Member

@jeremyletang jeremyletang commented Jun 7, 2021 •
edited by ValentinTrinque

Add the initial uint256 type for domain types.

linked to #3005

@ValentinTrinque ValentinTrinque changed the title start uint256 type From uint64 to uint256 (main branch) Jun 14, 2021
This was referenced Jun 14, 2021
Merged
Closed
@ValentinTrinque
Copy link
Contributor

Working on processor

@ValentinTrinque ValentinTrinque mentioned this pull request Jun 22, 2021
Merged
@EVODelavega EVODelavega force-pushed the feature/uint256 branch 2 times, most recently from 7779771 to 9b642fd Compare June 24, 2021 15:18
@EVODelavega EVODelavega marked this pull request as ready for review July 1, 2021 16:17
jeremyletang and others added 20 commits July 2, 2021 16:17
@jeremyletang
start uint256 type
713c8dc
@EVODelavega @jeremyletang
port all the matching engine to use the uint256 (no tests ported for …
8f68086 
…now)
@jeremyletang
wip port matching engine tests
32d64eb
@jeremyletang
matching package fully ported
131df37
@jeremyletang
add the Bytes method + fix hash in matching engine
94e5589
@peterbarrow @jeremyletang
Starting work on uint256
ef138a5
@peterbarrow @jeremyletang
Fixed unit tests
208e49b
@peterbarrow @jeremyletang
Fixed layout and logic issues
0b82ecd
@EVODelavega @jeremyletang
commit changes before rebase
fb47dda
@EVODelavega @jeremyletang
Switch to uint256 in settlement engine
6550808
@EVODelavega @jeremyletang
add Delta func for uint
7e4bd63
@EVODelavega @jeremyletang
Use uint256 in calcMTM, only cast delta to int64
0d3b9c7
@EVODelavega @jeremyletang
Preserve uint256 for positions API
db0661e
@EVODelavega @jeremyletang
create transfer types with uint256, update product types along the way
dabc770
@EVODelavega @jeremyletang
use uint256 in MTM calculations
f09d861
@EVODelavega @jeremyletang
Add sum util func, makes it easier to write code comparing things lik…
88170e2 
…e sum of balances
@EVODelavega @jeremyletang
Rename Sum method to AddSum for clarity
4a6a2ed
@EVODelavega @jeremyletang
Add uint support to oracle, and update products accordingly
85ba145
@EVODelavega @jeremyletang
review changes
971831b
@EVODelavega @jeremyletang
Add type to make calculation code a bit cleaner
5c3bc2c
peterbarrow and others added 25 commits July 2, 2021 16:18
@peterbarrow @jeremyletang
More fixes
f882ac2
@peterbarrow @jeremyletang
Some more fixes
6ce51f8
@EVODelavega @jeremyletang
Start fixing integration tests
cabe87f
@EVODelavega @jeremyletang
Integration tests half way
14f644c
@EVODelavega @jeremyletang
Strange LP submission issue, next to last feature
bb62420
@EVODelavega @jeremyletang
Fix log output
0f61f6e
@EVODelavega @jeremyletang
Fix price monitoring rounding issue
55347c6
@EVODelavega @jeremyletang
Work out what is going on with LP orders
01b3bd4
@EVODelavega @jeremyletang
Fix integration tests
a0b0d7c
@EVODelavega @jeremyletang
Fix price monitoring tests
fbee36f
@EVODelavega @jeremyletang
Remove debug line
72132f4
@EVODelavega @jeremyletang
Address staticcheck complaints
23e4e18
@EVODelavega @jeremyletang
make staticcheck happy
e04934d
@EVODelavega @jeremyletang
Damn spelling
08f3a34
@jeremyletang
fix a couple of panics
39d95d8
@jeremyletang
couple of fixes
6b953eb
@jeremyletang
more fixes
a90eeae
@EVODelavega @jeremyletang
Fix LP events being dropped
cd4d57b
@EVODelavega @jeremyletang
Ensure amount is signed (correctly) in loss soc proto event
dddac71
@EVODelavega @jeremyletang
Remove dead code
3835465
@EVODelavega @jeremyletang
remove double conversion, clean up a bit
38ca52d
@EVODelavega @jeremyletang
Remove redundant clone + initialise cleanup
bd0ed4e
@EVODelavega @jeremyletang
remove dead code
4a54b48
@EVODelavega @jeremyletang
Complete cleanup after side-by-side
bb2e871
@jeremyletang
fix collateral engine transfer requests processing
d665828
@gordsport gordsport linked an issue Jul 2, 2021 that may be closed by this pull request
Refinement: A proposed path of action to replace uint64s in the core #3005
Closed
15 tasks
@jeremyletang jeremyletang merged commit 21c5806 into develop Jul 2, 2021
@jeremyletang jeremyletang deleted the feature/uint256 branch July 13, 2021 15:22
@edd edd mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EVODelavega EVODelavega EVODelavega approved these changes

@peterbarrow peterbarrow peterbarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refinement: A proposed path of action to replace uint64s in the core
4 participants
@jeremyletang @ValentinTrinque @EVODelavega @peterbarrow