Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation without decimals in liquidity target #3693

Merged
merged 2 commits into from Jul 6, 2021

Conversation

jeremyletang
Copy link
Member

@jeremyletang jeremyletang commented Jul 5, 2021

Replacing the calculation using decimals by uint256 in the liquidity target package.

We are currently spending a considerable amount of time just converting from and into decimals / uint256 in this package.

@jeremyletang jeremyletang marked this pull request as ready for review July 6, 2021 09:48
@jeremyletang jeremyletang changed the title try to do calculation without decimals Calculation without decimals in liquidity target Jul 6, 2021
Copy link
Member

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyletang jeremyletang merged commit 495b5c2 into develop Jul 6, 2021
@jeremyletang jeremyletang deleted the feature/improve-calculations-uint256 branch July 13, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants