added loss socialisation to final settlement #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyletang
requested review from
EVODelavega,
jeremyletang and
a team
and removed request for
EVODelavega
| @@ -482,6 +610,11 @@ func (e *Engine) FinalSettlement(ctx context.Context, marketID string, transfers | |||
| } | |||
| responses = append(responses, res) | |||
| } | |||
|
|
|||
| if !settle.Balance.IsZero() { | |||
| return nil, ErrSettlementBalanceNotZero | |||
There was a problem hiding this comment.
Same here, this should probably be a panic thinking of it?
yes, not empty but not enough to cover losses. There's both a unit test and an integration test. |
peterbarrow
approved these changes
Jul 14, 2021
collateral/engine.go
Outdated
Comment on lines
459
to
465
| if err != nil { | ||
| e.log.Error( | ||
| "Failed to get system accounts required for final settlement", | ||
| logging.Error(err), | ||
| ) | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
This was above the loop, should this be inside the loop now?
collateral/engine_test.go
Outdated
| marginMoneyTrader, err := eng.Engine.CreatePartyMarginAccount(context.Background(), moneyTrader, testMarketID, testMarketAsset) | ||
| _, _ = eng.Engine.CreatePartyGeneralAccount(context.Background(), winTrader1, testMarketAsset) | ||
| _, err = eng.Engine.CreatePartyMarginAccount(context.Background(), winTrader1, testMarketID, testMarketAsset) | ||
| // eng.Engine.IncrementBalance(context.Background(), margin, 0) |
collateral/engine_test.go
Outdated
| err = eng.Engine.IncrementBalance(context.Background(), marginMoneyTrader, num.Sum(priceX3, price, price)) | ||
| _, _ = eng.Engine.CreatePartyGeneralAccount(context.Background(), winTrader2, testMarketAsset) | ||
| _, err = eng.Engine.CreatePartyMarginAccount(context.Background(), winTrader2, testMarketID, testMarketAsset) | ||
| // eng.Engine.IncrementBalance(context.Background(), margin, 700) |
EVODelavega
reviewed
Jul 15, 2021
|
|
||
| // accumulate the expected transfer size | ||
| expCollected.AddSum(req.Amount) | ||
| expectCollected = expectCollected.Add(num.DecimalFromUint(req.Amount)) |
There was a problem hiding this comment.
Not sure why this is a decimal
EVODelavega
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1908