Add some logging + height/version handling fixes #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwestgarth
previously approved these changes
Nov 22, 2021
EVODelavega
force-pushed
the
hotfix-snapshot-versions
branch
2 times, most recently
from
cf4fb5b
to
a42c372
Compare
EVODelavega
force-pushed
the
hotfix-snapshot-versions
branch
from
a42c372
to
41997df
Compare
wwestgarth
previously approved these changes
Nov 23, 2021
jeremyletang
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging of max and min heights found in store, remove old versions when saving past cap, default number of versions to 1, to avoid issues with invalid config values like -1 or 0.
Fixes #4419