Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 if mint amount is invalid, and update faucet README (#4440) #4456

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Return 400 if mint amount is invalid, and update faucet README (#4440) #4456

merged 2 commits into from
Nov 30, 2021

Conversation

wwestgarth
Copy link
Contributor

@wwestgarth wwestgarth commented Nov 29, 2021 •
edited

closes #4440

I was in the area. The README for running the faucet has been updated too, it was a little out of date.

@wwestgarth wwestgarth self-assigned this Nov 29, 2021
@wwestgarth wwestgarth requested a review from a team November 29, 2021 12:06
@wwestgarth wwestgarth marked this pull request as ready for review November 29, 2021 12:06
@wwestgarth wwestgarth merged commit accf506 into develop Nov 30, 2021
@wwestgarth wwestgarth deleted the 4440-return-400-on-bad-input-update-readme branch November 30, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarrow peterbarrow peterbarrow approved these changes

Assignees

@wwestgarth wwestgarth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depositing more that maximal amount using faucet returns 500
2 participants
@wwestgarth @peterbarrow