4449 nullchain without eth chain #4463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwestgarth
force-pushed
the
4449-nullchain-without-eth-chain
branch
from
3dca30f
to
7199501
Compare
ze97286
reviewed
Dec 3, 2021
| for k := range appstate.Validators { | ||
| pubKey, _ := base64.StdEncoding.DecodeString(k) | ||
| validators = append(validators, | ||
| abci.ValidatorUpdate{ |
There was a problem hiding this comment.
you could do:
power := /does it matter here? if not, just 0/
validators = append(validators, abci.UpdateValidator(pubkey, power, "")
ze97286
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4449
When using the nullchain we no longer dial to the Ethereum chain. Staking accounts are mocked by instead reading the balance from the general account in the collateral engine for a built-int asset with a particular name. See the README for more details.
There are also some other misc. fixes.