feat: report partial batch instruction processing error

[jeremyletang]

close #7843

[edd]

This will be great for block explorer! I can't add much to the review though. New status code looks good.

[jeremyletang]

Can you make the wallet aware of this new status code and handle it appropriately:

func (s *API) writeTxError(w http.ResponseWriter, r *api.SubmitTransactionResponse) {
	var code int
	switch r.Code {
	case TxnSpamError:
		code = http.StatusTooManyRequests
	case TxnUnknownCommandError, TxnValidationFailure, TxnDecodingFailure:
		code = http.StatusBadRequest
	case TxnInternalError:
		code = http.StatusInternalServerError
	default:
		s.log.Error("unknown transaction code", zap.Uint32("code", r.Code))
		code = http.StatusInternalServerError
	}
	s.writeError(w, newErrorResponse(r.Data), code)
}

hum yes. Any thoughts on what http status code would work well for this?

[wwestgarth]

Can you make the wallet aware of this new status code and handle it appropriately:

func (s *API) writeTxError(w http.ResponseWriter, r *api.SubmitTransactionResponse) {
	var code int
	switch r.Code {
	case TxnSpamError:
		code = http.StatusTooManyRequests
	case TxnUnknownCommandError, TxnValidationFailure, TxnDecodingFailure:
		code = http.StatusBadRequest
	case TxnInternalError:
		code = http.StatusInternalServerError
	default:
		s.log.Error("unknown transaction code", zap.Uint32("code", r.Code))
		code = http.StatusInternalServerError
	}
	s.writeError(w, newErrorResponse(r.Data), code)
}

hum yes. Any thoughts on what http status code would work well for this?

I deleted my comment because I realised it didn't really matter. The error only comes through at delivering and not checking, so the wallet would never see it anyway.