calculate auciton closing time based on vote close #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVODelavega
force-pushed
the
auction-duration-validation
branch
from
0059eb1
to
6fc1a70
Compare
…time Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
EVODelavega
force-pushed
the
auction-duration-validation
branch
from
8230b69
to
a275dad
Compare
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
zale144
reviewed
Jun 7, 2023
| @@ -369,8 +369,8 @@ func (e *Engine) IsEligibleForProposerBonus(marketID string, value *num.Uint) bo | |||
| } | |||
|
|
|||
| // SubmitMarket submits a new market configuration to the network. | |||
| func (e *Engine) SubmitMarket(ctx context.Context, marketConfig *types.Market, proposer string) error { | |||
| return e.submitOrRestoreMarket(ctx, marketConfig, proposer, true) | |||
| func (e *Engine) SubmitMarket(ctx context.Context, marketConfig *types.Market, proposer string, oos time.Time) error { | |||
There was a problem hiding this comment.
oos is opening auction start? Shouldn't it be oas then? Or maybe something more obvious like auctionStart or whatever?
zale144
previously approved these changes
Jun 7, 2023
Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
jeremyletang
approved these changes
Jun 7, 2023
jeremyletang
added a commit
that referenced
this pull request
Jun 8, 2023
Signed-off-by: Jeremy Letang <me@jeremyletang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix closing
close #8451