Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mkVegaModel #157

Merged
merged 3 commits into from Oct 9, 2018
Merged

Fix mkVegaModel #157

merged 3 commits into from Oct 9, 2018

Conversation

oshikiri
Copy link
Collaborator

@oshikiri oshikiri commented Sep 17, 2018 •
edited

@oshikiri
Fix vegaLiteSpec and mkVegaModel
c59cd52 
Squashed commit of the following:

    Add mkVegaModel to travis-ci

    Fix output path at FromSchemaSpec

    Use FlatSpec style at FromSchemaSpec

    Fix dependency on vegaLiteSpec

    Additional `value` is required.
    * vegas-viz#127
    * https://www.scala-sbt.org/1.0/docs/Migrating-from-sbt-013x.html#Migrating+when+using+%2C++or

    Add to CONTRIBUTING.md

    Fix Spec object annotation

    Add FromSchemaAnnotationSpec and vegaLiteSpec/test

    Fix some typos and format issues on CONTRIBUTING.md
@oshikiri
Add a do-not-edit messages
ecd1a95
@oshikiri
Apply sbt mkVegaModel
99f5958
@codecov-io
Copy link

codecov-io commented Oct 9, 2018 •
edited

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   20.91%   20.91%           
=======================================
  Files          27       27           
  Lines        1783     1783           
  Branches        5        5           
=======================================
  Hits          373      373           
  Misses       1410     1410
Impacted Files Coverage Δ
core/src/main/scala/vegas/spec/Spec.scala 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6818c65...99f5958. Read the comment docs.

@oshikiri
Copy link
Collaborator Author

oshikiri commented Oct 9, 2018

@aishfenton @dbtsai Could you please review this?

@dbtsai dbtsai merged commit ec147c6 into vegas-viz:master Oct 9, 2018
@oshikiri oshikiri deleted the fix-mkvegamodel branch October 10, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aishfenton aishfenton Awaiting requested review from aishfenton

@dbtsai dbtsai Awaiting requested review from dbtsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oshikiri @codecov-io @aishfenton @dbtsai