Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_altair() #41

Closed
ijlyttle opened this issue May 6, 2018 · 2 comments
Closed

Update install_altair() #41

ijlyttle opened this issue May 6, 2018 · 2 comments

Comments

@ijlyttle
Copy link
Collaborator

ijlyttle commented May 6, 2018

Possible values of stage are:

  • "release", to install the released version on Conda-Forge
  • "candidate", to install a release-candidate using PyPi

In the future:

  • "github", to install from the Altair GitHub repository

If the "release" version is newer than the "candidate" version, specifying "candidate" will generate a message then install the "release" version.

To support this, create some internal functions:

  • install_altair_release()
  • install_altair_candidate()
@ijlyttle ijlyttle mentioned this issue May 6, 2018
7 tasks
@ijlyttle ijlyttle moved this from In progress to To do in Necessary conditions for first publicity May 6, 2018
@ijlyttle
Copy link
Collaborator Author

ijlyttle commented May 6, 2018

Instead of creating new functions, capture the arguments to install_altar as a list, then modify that list according to stage and method (conda or virtualenv). Finally, call conda_install() or virtualenv_install().

@ijlyttle ijlyttle changed the title Add stage argument to install_altair() Update install_altair() May 6, 2018
@ijlyttle
Copy link
Collaborator Author

ijlyttle commented May 6, 2018

Decided to do things differently: there is a version argument that defaults to getOption("altair.python.version").

You have to declare explicitly if you are using "conda" or "virtualenv".

ijlyttle added a commit that referenced this issue May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant