Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack overflow error #15

Open
hax opened this issue Oct 19, 2012 · 4 comments
Open

stack overflow error #15

hax opened this issue Oct 19, 2012 · 4 comments

Comments

@hax
Copy link

hax commented Oct 19, 2012

I wrote a parser which trying to parse something like interpolation expression, it is reported that stack overflow! But I tried the original version, it works.

It seems that the rewrite version is not as good as the old one. I also found that foreign rule is not supported in the new version, which is a very useful feature. Some issues I submitted here also only occur in this new version. So I'm just curious why rewrite it? What's the benifit of the new version?

@indutny
Copy link
Collaborator

indutny commented Oct 20, 2012

Well, benefit is speed. I'll should find time to benchmark them both and post results somewhere.

@indutny
Copy link
Collaborator

indutny commented Jan 29, 2013

So, considering this is not really an issue, I decided to close it :)

@indutny indutny closed this as completed Jan 29, 2013
@hax
Copy link
Author

hax commented Jan 30, 2013

This is really an issue. My project Jedi (https://github.com/hax/jedi) is a template engine, the parser and the transpiler of it are written in ometajs, but only original version works. This rewritten version always report stack overflow error. Though the original version may be too slow (it cost 5 to 10 seconds for compiling large template in my case), it works at least. So I hope you can resolve the problems and I can move to this new implemention. Thank you.

@indutny
Copy link
Collaborator

indutny commented Jan 30, 2013

I'll look into it, but I don't think it can really be solved...

@indutny indutny reopened this Jan 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants