Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swarmpit #375

Merged
merged 3 commits into from Jul 11, 2017
Merged

Add swarmpit #375

merged 3 commits into from Jul 11, 2017

Conversation

jirkapenzes
Copy link
Contributor

@jirkapenzes jirkapenzes commented Jul 10, 2017

I added Swarmpit app into your awesome Docker tools.

Copy link
Owner

@veggiemonk veggiemonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jirkapenzes thank you for your contribution but the description you give and the changes in the file are not really related!
On top of that, could you please try to follow the contributing guidelines ? English letter order, no duplicates

README.md Outdated
@@ -364,6 +364,7 @@ Services to securely store your Docker images.
* [Rancher](https://github.com/rancher/rancher) - An open source project that provides a complete platform for operating Docker in production by [@rancher][rancher].
* [Serf](https://github.com/hashicorp/serf) - Service orchestration and management tool by [@hashicorp][hashicorp]
* [Shipyard](https://github.com/shipyard/shipyard) - Composable Docker Management
* [Docker Swarm](https://github.com/docker/swarm) (Swarm: a Docker-native clustering system)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? swarmpit ???

@jirkapenzes
Copy link
Contributor Author

@veggiemonk Thanks for review and sorry. That was bad commit. Could you please check PR again? Thanks.

Copy link
Owner

@veggiemonk veggiemonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice project and nice website!
Just one small thing and the project will be on the list!
Good job!

README.md Outdated
@@ -364,6 +364,7 @@ Services to securely store your Docker images.
* [Rancher](https://github.com/rancher/rancher) - An open source project that provides a complete platform for operating Docker in production by [@rancher][rancher].
* [Serf](https://github.com/hashicorp/serf) - Service orchestration and management tool by [@hashicorp][hashicorp]
* [Shipyard](https://github.com/shipyard/shipyard) - Composable Docker Management
* [Swarmpit](http://swarmpit.io/) - Lightweight Docker Swarm orchestration. Swarmpit provides clean way to manage your Docker Swarm cluster with various handful features such Service management, Smart search, Shared access, Private registries and more to come soon.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url should be the project on github rather than the websites

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing, no need for capital letter at the begining of each work.

Lightweight Docker Swarm orchestration. Swarmpit provides clean way to manage your Docker Swarm cluster with various handful features such service management, smart search, shared access, private registries.

I removed the "more to come soon" as you can come back and add them here when the features are ready :D

@veggiemonk veggiemonk mentioned this pull request Jul 11, 2017
@jirkapenzes
Copy link
Contributor Author

Thanks. I push new commit with changes ;)

@veggiemonk veggiemonk merged commit ddd14e1 into veggiemonk:master Jul 11, 2017
@veggiemonk
Copy link
Owner

@jirkapenzes Good work! Thanks for your contribution. It looks like a nice project!
If we can help you in any way, let us know!

Awesome-docker team

@jirkapenzes
Copy link
Contributor Author

@veggiemonk Big thanks! Would we love to get feedback about our app. If you have time or if you know someone who have time please try it :) Feel free for feedbacks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants