Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in interface file loading #342

Open
wenkokke opened this issue Dec 20, 2022 · 4 comments · May be fixed by #379
Open

Race condition in interface file loading #342

wenkokke opened this issue Dec 20, 2022 · 4 comments · May be fixed by #379
Assignees
@MatthewDaggitt
Labels
bug Something isn't working compiler:other

Comments

@wenkokke
Copy link
Collaborator

wenkokke commented Dec 20, 2022 •
edited

I'm getting the following error when running the test suite:

LiftAndElimIf
    liftIfAnn: FAIL
      Exception: /home/runner/.vehicle/libraries/stdlib/stdlib.vclo:
            withBinaryFile: resource busy (file is locked)
      Use -p '/liftIfAnn/' to rerun this test only.

Could this be a race condition in the mechanism which loads the interface file.
@wenkokke
Copy link
Collaborator Author

I'm guessing what is happening is that the test suite runs multiple vehicle processes in parallel, and they all try to compile the standard library and write the interface at the same time.

@wenkokke wenkokke mentioned this issue Dec 20, 2022
Merged
wenkokke added a commit that referenced this issue Dec 20, 2022
@wenkokke
Fix performance regression
ebc5b01 
Revert to 7850891

* Switch to ormolu
* Run ormolu
* Add benchmark script
* Clean up .cabal file
* Fix warnings in tests. Disable QuantifierLifting.
* Add ghc-debug and nothunks instrumentation
* Add HasMap type class (#332)
* Refactoring printing to use `Contextualised` to eliminate duplicate strategies (#337)
* Change CI test component to 'all'
* Force CI to run Tasty tests sequentially (#342)
* Change CI install component to vehicle:exe:vehicle
@wenkokke wenkokke mentioned this issue Dec 20, 2022
Closed
@wenkokke
Copy link
Collaborator Author

I've added a workaround, but not a fix, as part of #341 (14f6d2b).

@wenkokke wenkokke added bug Something isn't working compiler:other labels Dec 20, 2022
@wenkokke
Copy link
Collaborator Author

wenkokke commented Jan 5, 2023

When this is fixed, we should reenable the tests with -fghc-debug.

MatthewDaggitt added a commit that referenced this issue Jan 18, 2023
@MatthewDaggitt
Fixes #342 by handling error in object file race condition
db2afc1
@MatthewDaggitt MatthewDaggitt linked a pull request Jan 18, 2023 that will close this issue
Fixes #342 by handling error in object file race condition #379
Open
@wenkokke
Copy link
Collaborator Author

https://hackage.haskell.org/package/lukko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewDaggitt MatthewDaggitt

Labels
bug Something isn't working compiler:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #342 by handling error in object file race condition vehicle-lang/vehicle
2 participants
@MatthewDaggitt @wenkokke