Merge pull request #21 from adwd/feat-knowntypenames

implement KnownTypeNames validator

validator/known_type_names.go

@@ -0,0 +1,59 @@
+package validator
+
+import (
+	"github.com/vektah/gqlparser"
+)
+
+func init() {
+	addRule("KnownTypeNames", func(observers *Events, addError addErrFunc) {
+		observers.OnOperation(func(walker *Walker, operation *gqlparser.OperationDefinition) {
+			for _, vdef := range operation.VariableDefinitions {
+				typeName := vdef.Type.Name()
+				def := walker.Schema.Types[typeName]
+				if def != nil {
+					continue
+				}
+
+				addError(
+					Message(`Unknown type "%s".`, typeName),
+				)
+			}
+		})
+
+		observers.OnInlineFragment(func(walker *Walker, parentDef *gqlparser.Definition, inlineFragment *gqlparser.InlineFragment) {
+			typedName := inlineFragment.TypeCondition.Name()
+			if typedName == "" {
+				return
+			}
+
+			def := walker.Schema.Types[typedName]
+			if def != nil {
+				return
+			}
+
+			addError(
+				Message(`Unknown type "%s".`, typedName),
+			)
+		})
+
+		observers.OnFragment(func(walker *Walker, parentDef *gqlparser.Definition, fragment *gqlparser.FragmentDefinition) {
+			typeName := fragment.TypeCondition.Name()
+			def := walker.Schema.Types[typeName]
+			if def != nil {
+				return
+			}
+
+			var possibleTypes []string
+			for _, t := range walker.Schema.Types {
+				possibleTypes = append(possibleTypes, t.Name)
+			}
+
+			list := SuggestList(typeName, possibleTypes)
+
+			addError(
+				Message(`Unknown type "%s".`, typeName),
+				list,
+			)
+		})
+	})
+}

validator/suggestionList.go

@@ -29,7 +29,7 @@ func suggestionList(input string, options []string) []string {
 }
 
 func calcThreshold(a, b string) (threshold int) {
-	if len(a) <= len(b) {
+	if len(a) >= len(b) {
 		threshold = len(a) / 2
 	} else {
 		threshold = len(b) / 2

validator/validate_test.go

@@ -41,6 +41,7 @@ func TestSpec(t *testing.T) {
 	t.Run("KnownArgumentNames", runSpec(schemas, deviations, "../spec/validation/KnownArgumentNames.yml"))
 	t.Run("KnownDirectives", runSpec(schemas, deviations, "../spec/validation/KnownDirectives.yml"))
 	t.Run("KnownFragmentNames", runSpec(schemas, deviations, "../spec/validation/KnownFragmentNames.yml"))
+	t.Run("KnownTypeNames", runSpec(schemas, deviations, "../spec/validation/KnownTypeNames.yml"))
 
 	t.Run("LoneAnonymousOperation", runSpec(schemas, deviations, "../spec/validation/LoneAnonymousOperation.yml"))