check for non enum values on validation

vektah · Jun 25, 2022 · dd63349 · dd63349
1 parent 0e3e4c2
commit dd63349
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/validator/schema.go b/validator/schema.go
@@ -277,6 +277,13 @@ func validateDefinition(schema *Schema, def *Definition) *gqlerror.Error {
 		if len(def.EnumValues) == 0 {
 			return gqlerror.ErrorPosf(def.Position, "%s %s: must define one or more unique enum values.", def.Kind, def.Name)
 		}
+		for _, value := range def.EnumValues {
+			for _, nonEnum := range [3]string{"true", "false", "null"} {
+				if value.Name == nonEnum {
+					return gqlerror.ErrorPosf(def.Position, "%s %s: non-enum value %s.", def.Kind, def.Name, value.Name)
+				}
+			}
+		}
 	case InputObject:
 		if len(def.Fields) == 0 {
 			return gqlerror.ErrorPosf(def.Position, "%s %s: must define one or more input fields.", def.Kind, def.Name)

diff --git a/validator/schema_test.yml b/validator/schema_test.yml
@@ -668,3 +668,11 @@ type references:
     error:
       message: "Undefined type FooBar."
       locations: [{line: 1, column: 21}]
+
+  - name: Invalid enum value
+    input: |
+      enum Enum { true }
+
+    error:
+      message: "ENUM Enum: non-enum value true."
+      locations: [{line: 1, column: 6}]