Fixes #231: Parsing a field type with a bang should not increase the …

…line number (#236) Co-authored-by: Ahmad Moudani <ahmad.moudani@crowdstrike.com>
vektah · Sep 9, 2022 · eae2341 · eae2341
1 parent 88d9590
commit eae2341
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/parser/query.go b/parser/query.go
@@ -336,7 +336,6 @@ func (p *parser) parseTypeReference() *Type {
 	}
 
 	if p.skip(lexer.Bang) {
-		typ.Position = p.peekPos()
 		typ.NonNull = true
 	}
 	return &typ

diff --git a/parser/schema_test.go b/parser/schema_test.go
@@ -1,6 +1,7 @@
 package parser
 
 import (
+	"github.com/stretchr/testify/assert"
 	"github.com/vektah/gqlparser/v2/gqlerror"
 	"testing"
 
@@ -18,7 +19,30 @@ func TestSchemaDocument(t *testing.T) {
 			}
 		}
 		return testrunner.Spec{
-			AST:   ast.Dump(doc),
+			AST: ast.Dump(doc),
 		}
 	})
 }
+
+func TestTypePosition(t *testing.T) {
+	t.Run("type line number with no bang", func(t *testing.T) {
+		schema, parseErr := ParseSchema(&ast.Source{
+			Input: `type query {
+						me: User
+					}
+			`,
+		})
+		assert.Nil(t, parseErr)
+		assert.Equal(t, 2, schema.Definitions.ForName("query").Fields.ForName("me").Type.Position.Line)
+	})
+	t.Run("type line number with bang", func(t *testing.T) {
+		schema, parseErr := ParseSchema(&ast.Source{
+			Input: `type query {
+						me: User!
+					}
+			`,
+		})
+		assert.Nil(t, parseErr)
+		assert.Equal(t, 2, schema.Definitions.ForName("query").Fields.ForName("me").Type.Position.Line)
+	})
+}