Fix arguments comparison logic for overlapping fields #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll update the PR to match the implementation in |
0xhmn
force-pushed
the
hmn/fix-conflict-logic
branch
2 times, most recently
from
00292f8
to
2675fc6
Compare
bofia
reviewed
Oct 14, 2021
| for _, arg1 := range args1 { | ||
| var match *ast.Argument |
There was a problem hiding this comment.
Was trying to follow this logic. I can change it to boolean.
bofia
reviewed
Oct 14, 2021
| "github.com/vektah/gqlparser/v2/ast" | ||
| . "github.com/vektah/gqlparser/v2/validator" | ||
| "reflect" |
0xhmn
force-pushed
the
hmn/fix-conflict-logic
branch
from
2675fc6
to
2c30ea7
Compare
|
Hello - Any chance we can get a review on this PR? |
|
I have just hit this as a blocking issue :sadpanda: I've created an alternative that includes tests @ #170 |
|
Closing in favor of #170 but thanks for getting this started! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current argument comparison seems different from
graphql-jswhich is resulting in unexpected behavior like this.Instead of comparing all the arguments to each other, we just need to compare the corresponding ones (with the same
argument.Name)