Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated prelude.graphql for the beta spec #200

Merged

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Feb 28, 2022

@StevenACoffman The release here (only gqlparser) is fine but don't release gqlgen yet. we have to fix this (Moreover, it cannot be started unless gqlparser is released.)

99designs/gqlgen#1986

@StevenACoffman StevenACoffman merged commit a188593 into vektah:master Feb 28, 2022
@Code-Hex
Copy link
Contributor Author

Code-Hex commented Feb 28, 2022

@StevenACoffman Maybe you don't understand so write in detail.

  1. We want to update to the latest spec. And prelude is updated. this means introspection query has been supported new resolvers (SpecifiedByURL, Description etc for now)
  2. gqlgen (v0.16.0) does not support for new introspection resolvers. So, when gqlparser updates the prelude and gqlgen (combined v0.16.0 and the new gqlparser if released) will try to create a new resolver automatically, and there will be a problem where you can't build it. (like Problem with @deprecated directive in input fields 99designs/gqlgen#1636)
  3. This is where PR comes in. Prevent the automatic creation of new resolvers for introspection.

So what I'm saying is that when you update the spec, you should also update gqlgen as soon as possible.

I think the only way to avoid the problem you're concerned about is to update both of them. And if you want my support, you'll should to mind the time difference. (JST)

@Code-Hex Code-Hex deleted the update/prelude-for-deprecated-arg branch February 28, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants