Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description formatting (possible " character) #289

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

blmhemu
Copy link
Contributor

@blmhemu blmhemu commented Jan 8, 2024

Fixes #288 (Descriptions with " will now be formatted correctly)

I have:

  • Added tests covering the bug / feature
  • Updated any relevant documentation

@blmhemu blmhemu changed the title Fix description Fix description formatting (possible " character) Jan 8, 2024
@coveralls
Copy link

Coverage Status

coverage: 88.682% (-0.007%) from 88.689%
when pulling 8ca0cc9 on blmhemu:fix-description
into bf1736a on vektah:master.

@StevenACoffman StevenACoffman merged commit a942954 into vektah:master Jan 8, 2024
5 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks! I really appreciate you fixing this. Looking forward to your next PR improvement!

@blmhemu blmhemu deleted the fix-description branch January 9, 2024 08:41
@blmhemu
Copy link
Contributor Author

blmhemu commented Jan 18, 2024

Hey ! Could you possibly tag a new release ?

@StevenACoffman
Copy link
Collaborator

Done! Thanks for the nudge. I was waiting for another PR, but it looks like that has lost momentum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Trivial] Formatter - Descriptions with a double quotes fail to produce correct graphql code.
3 participants