-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【確認中】スライダーアイテムをカスタムカラーパレットに対応 #925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…x/slider/custome-color
add GenerateBgImageSliderItem component
GenerateBgImageSliderItem場所を調整
sysbird
approved these changes
Jan 27, 2022
そういえば、枠線ブロックの際は気づかず反映してしまいました… @kurudrive |
* develop: [ Change version ] 1.22.3 fix : 見出しブロックが全幅にならない不具合修正 [ Change version ] 1.22.2 [ 不具合修正 ][ 選択投稿ブロック ][ vk posts ] 投稿idが正しく反映されない(結果リンクターゲットのblankが付かない)不具合を修正 # Conflicts: # inc/vk-blocks/languages/vk-blocks.pot # readme.txt
旧ブロック / 新ブロック × WP5.8 / 5.9で確認しました |
事前告知について |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #765 #763
スライダーブロックのカスタムカラーに対応しました。
確認お願いします。
実装方法メモ
基本的にはコアのcoverブロックを参考
透過設定のcss
リリース時に相談したいこと
実際にクローンして確認していただきたいだのですがHTMLが変わります。
特に背景画像がない時に変わるので以下にHTMLを貼っておきます。
master
このブランチ
<div class="vk_slider_item-background-area"></div>
が入ります。以前のアコーディオンブロックのようにリリースする前に事前告知したほうが良いですか。問題ないですかね