Show support for pointer type replacements

vektra · Feb 8, 2024 · e724b8a · e724b8a
1 parent 4b08243
commit e724b8a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/.mockery.yaml b/.mockery.yaml
@@ -51,7 +51,7 @@ packages:
       ReplaceGenericSelf:
         config:
           replace-type:
-            - github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf[-T]=github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf
+            - github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf[-T]=github.com/vektra/mockery/v2/pkg/fixtures.*ReplaceGenericSelf
   github.com/vektra/mockery/v2/pkg/fixtures/recursive_generation:
     config:
       recursive: True

diff --git a/docs/features.md b/docs/features.md
@@ -102,6 +102,12 @@ If a type constraint needs to be removed and replaced with a type, target the co
 mockery --replace-type github.com/vektra/mockery/v2/baz/internal/foo.InternalBaz[-T]=baz:github.com/vektra/mockery/v2/baz.Baz
 ```
 
+When replacing a generic constraint, you can replace the type with a pointer by adding a '*' before the output type name.
+
+```shell
+mockery --replace-type github.com/vektra/mockery/v2/baz/internal/foo.InternalBaz[-T]=baz:github.com/vektra/mockery/v2/baz.*Baz
+```
+
 `packages` configuration
 ------------------------
 :octicons-tag-24: v2.21.0

diff --git a/mocks/github.com/vektra/mockery/v2/pkg/fixtures/ReplaceGenericSelf.go b/mocks/github.com/vektra/mockery/v2/pkg/fixtures/ReplaceGenericSelf.go
diff --git a/pkg/generator_test.go b/pkg/generator_test.go
@@ -764,7 +764,7 @@ func (s *GeneratorSuite) TestReplaceTypeGeneric() {
 	cfg := GeneratorConfig{InPackage: false, ReplaceType: []string{
 		"github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGeneric[-TImport]=github.com/vektra/mockery/v2/pkg/fixtures/redefined_type_b.B",
 		"github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGeneric[TConstraint]=github.com/vektra/mockery/v2/pkg/fixtures/constraints.Integer",
-		"github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf[-T]=github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf",
+		"github.com/vektra/mockery/v2/pkg/fixtures.ReplaceGenericSelf[-T]=github.com/vektra/mockery/v2/pkg/fixtures.*ReplaceGenericSelf",
 	}}
 
 	s.checkGenerationRegexWithConfig("generic.go", "ReplaceGeneric", cfg, []regexpExpected{
@@ -781,8 +781,8 @@ func (s *GeneratorSuite) TestReplaceTypeGeneric() {
 	s.checkGenerationRegexWithConfig("generic.go", "ReplaceGenericSelf", cfg, []regexpExpected{
 		// type ReplaceGenericSelf struct
 		{true, regexp.MustCompile(`type ReplaceGenericSelf struct`)},
-		// func (_m *ReplaceGenericSelf) A() ReplaceGenericSelf
-		{true, regexp.MustCompile(`func \(_m \*ReplaceGenericSelf\) A\(\) ReplaceGenericSelf`)},
+		// func (_m *ReplaceGenericSelf) A() *ReplaceGenericSelf
+		{true, regexp.MustCompile(`func \(_m \*ReplaceGenericSelf\) A\(\) \*ReplaceGenericSelf`)},
 	})
 }