Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve documentation #493

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

CorentinClabaut
Copy link
Contributor

Description

closes #492

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18

How Has This Been Tested?

NA

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

README.md Outdated
@@ -359,6 +371,7 @@ The following descriptions provide additional elaboration on a few common parame
| `--print` | Use `mockery --print` to have the resulting code printed out instead of written to disk. |
| `--exported` | Use `mockery --exported` to generate public mocks for private interfaces. |
| `--with-expecter` | Use `mockery --with-expecter` to generate `EXPECT()` methods for your mocks. This is the preferred way to setup your mocks. |
| `--log-level` | Use `--log-level` to generate useful logs. Possible values are `trace`, `debug`, `info`, `warn`, `error`, `fatal`, `panic` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty self-explanatory from the CLI, probably unnecessary here in my view.

README.md Outdated
@@ -41,8 +42,14 @@ Visit the [releases page](https://github.com/vektra/mockery/releases) to downloa

Use the [Docker image](https://hub.docker.com/r/vektra/mockery)

Get mockery verion:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/verion/version

Probably don't need this, docker pull is self-explanatory

README.md Outdated
Requirement
-----------

For mockery to correctly generate mocks, the command has to be run on a module (i.e. your project has to have a go.mod file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe this should belong as a note under the Examples section. But good call, people do get caught by this 👍🏻

Copy link
Contributor Author

@CorentinClabaut CorentinClabaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@LandonTClipp LandonTClipp merged commit 1361e94 into vektra:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc improvement: Explicitly explain that mockery should be run on a module (with a go.mod file)
2 participants