Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recurse into submodules on recursive: true #740

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

LandonTClipp
Copy link
Collaborator

@LandonTClipp LandonTClipp commented Dec 19, 2023

Description

This PR changes mockery to not recurse into paths that contain a go.mod submodule. This is to help support monorepos that contain many modules. In this case, mockery should not be recursing into these because it causes issues, like in issue #706.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (446e0bf) 75.16639% compared to head (b248492) 75.17584%.

Files Patch % Lines
pkg/config/config.go 73.68421% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #740         +/-   ##
===================================================
+ Coverage   75.16639%   75.17584%   +0.00944%     
===================================================
  Files             10          10                 
  Lines           2404        2417         +13     
===================================================
+ Hits            1807        1817         +10     
- Misses           459         461          +2     
- Partials         138         139          +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This PR changes mockery to not recurse into paths that contain
a `go.mod` submodule. This is to help support monorepos that contain
many modules. In this case, mockery should not be recursing into these
because it causes issues, like in issue vektra#706.

fix deprecations in mkdocs

remove explicit lint step
@LandonTClipp LandonTClipp merged commit 4f9dc15 into vektra:master Dec 19, 2023
4 checks passed
@LandonTClipp LandonTClipp deleted the monorepo branch December 19, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when loading package, can only [...] in module-aware mode
1 participant